[Bug 754418] segment: Added gst_segment_position_from_stream_time()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754418

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310450|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 310450:
 --> (https://bugzilla.gnome.org/review?bug=754418&attachment=310450)

Thanks, looks mostly good. Just some cosmetic changes :)

::: gst/gstsegment.c
@@ +399,3 @@
     guint64 position)
 {
+  guint64 stream_time, start, stop, time;

Please put the change to the existing function where you rename this variable
into a different patch. That's cleanup :)

@@ +463,3 @@
+ *
+ * Returns: the position in the segment for @stream_time. This function
returns
+ * -1 when @stream_time is -1 or when it is not inside @segment.

Add "Since: 1.8" here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.