[Bug 755169] dashdemux: can we have multiple seek events at the same time?

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755169

--- Comment #31 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Vincent Penquerc'h from comment #30)
> Do you agree in principle with the merging of the object and manifest locks,
> as a prerequsite to building upon this change (that's the top patch in the
> tree, which I made a separate patch for now for clarity) ?

It's hard for me to understand what is the set of patches you propose for this
ticket. I assume they are the last 3 patches in your tree
(17a4a09cc82a43c26f2bc95bd303ef420e2930ba,
ec001f4e8511e57fdae7ed6eddf1f651fbf9ab78,
87db55f5092e9d0d03d6c0eb644bfd92ce061c11)
I have just reviewed the last 2 and had some comments (see above comments 28
and 29).
Sorry, but I don't understand what do you mean by "which I made a separate
patch for now for clarity".
For clarity, please propose a set of patches (marked for example 1/3, 2/3, 3/3)
that should be applied on the current master. Thus everyone can see what
changes you propose and in which order.

Regarding "the merging of the object and manifest locks": I believe we should
clearly document what is the purpose of each lock. At this moment, I can't tell
when the demux object lock should be used. I understand the reason for
api_lock, I would guess that manifest lock should be used whenever demux object
is accessed, but I cannot say when demux object lock should be taken.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.