[Bug 755480] TRY_GET leaks string pointer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 24 00:46:22 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755480

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311993|none                        |reviewed
             status|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 311993:
 --> (https://bugzilla.gnome.org/review?bug=755480&attachment=311993)

::: ges/ges-structured-interface.c
@@ -349,3 +350,3 @@
   if (layer_priority == -1)
     TRY_GET ("layer", G_TYPE_INT, &layer_priority, -1);
-  TRY_GET ("type", G_TYPE_STRING, &type_string, "GESUriClip");
+  TRY_GET ("type", G_TYPE_STRING, &type_string, g_strdup ("GESUriClip"));

Looks wrong to g_strdup the def value, I think it is leaked if we do not use
it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list