[Bug 755505] ges: trivial leakages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755505

--- Comment #9 from Justin J. Kim <justin.joy.9to5 at gmail.com> ---
Review of attachment 312000:
 --> (https://bugzilla.gnome.org/review?bug=755505&attachment=312000)

::: ges/ges-uri-asset.c
@@ +598,2 @@
   if (g_str_has_prefix (priv->uri, GES_MULTI_FILE_URI_PREFIX)) {
+    trackelement = GES_TRACK_ELEMENT (ges_multi_file_source_new (uri));

Up to this point, this is exactly same as left, but the different thing is
whether uri is freed at line 612.
I think I cannot free priv->uri directly because it is used by the other
functions.

@@ -595,3 @@
   if (g_str_has_prefix (priv->uri, GES_MULTI_FILE_URI_PREFIX)) {
-    trackelement =
-        GES_TRACK_ELEMENT (ges_multi_file_source_new (g_strdup (priv->uri)));

ges_####_file_source_new also copies string by g_strdup inside. Therefore, as a
result, one more duplicated string is created and not freed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.