[Bug 755251] gtksink: Rework threading around GtkWindow creation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755251

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312012|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312012:
 --> (https://bugzilla.gnome.org/review?bug=755251&attachment=312012)

::: ext/gtk/gstgtkbasesink.c
@@ +356,3 @@
+gst_gtk_base_sink_start (GstBaseSink * bsink)
+{
+  return ! !_invoke_on_main ((GThreadFunc) gst_gtk_base_sink_start_in_main,

stop() should probably be on main too? And _show_window_cb() maybe with the
_invoke_on_main() helper?

What about gst_gtk_base_sink_set_caps()? It calls into the widget from the
streaming thread. And show_frame()?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.