[Bug 755251] gtksink: Rework threading around GtkWindow creation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755251

--- Comment #9 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 312012:
 --> (https://bugzilla.gnome.org/review?bug=755251&attachment=312012)

::: ext/gtk/gstgtkbasesink.c
@@ +356,3 @@
+gst_gtk_base_sink_start (GstBaseSink * bsink)
+{
+  return ! !_invoke_on_main ((GThreadFunc) gst_gtk_base_sink_start_in_main,

> stop() should probably be on main too? And _show_window_cb() maybe with the _invoke_on_main() helper?

Done in new version

> What about gst_gtk_base_sink_set_caps()? It calls into the widget from the streaming thread. And show_frame()?

set_caps only calls gtk_base_sink_set_widget_format which is MT safe (no direct
call to Gtk itself).

show_frame calls gtk_gst_base_widget_set_buffer which in turns just does an
g_idle_add_full to set the buffer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.