[Bug 705579] Playbin prevents plugins requesting a GstContext to work properly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=705579

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312019|none                        |reviewed
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312019:
 --> (https://bugzilla.gnome.org/review?bug=705579&attachment=312019)

::: gst/gstelement.c
@@ +3073,3 @@
+  GST_OBJECT_LOCK (element);
+
+  context_type = gst_context_get_context_type (context);

I think this code should all be in the default implementation of set_context().
That would then allow subclasses to actually override this new behaviour.

@@ +3106,3 @@
+ * MT safe.
+ *
+ * Returns: (element-type Gst.Context) (transfer full): List of #GstContext

Sprinkle some "Since: 1.8" around here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.