[Bug 755343] funnel: Fix racy state change

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 24 03:15:46 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755343

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.6.0

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 2c60b7eb1fc8851296e7bbb209663bb0c0e53f21
Author: Stian Selnes <stian at pexip.com>
Date:   Mon Sep 21 13:58:51 2015 +0200

    funnel: Fix racy state change

    Iterator may need to be resynced, for instance if pads are released
    during state change.

    got_eos should be protected by the object lock of the element, not of
    the pad, as is the case throughout the rest of the funnel code.

    https://bugzilla.gnome.org/show_bug.cgi?id=755343

commit 0fbf1d3eb7feaa753cf1d0ec03546f854dd1f037
Author: Stian Selnes <stian at pexip.com>
Date:   Mon Sep 21 15:22:19 2015 +0200

    bin: element: Ignore activate result for removed pads on state change

    This fixes a race where a state change may return failure if it has
    request pads that are deactivated and removed (and thus have no
    parent) at the same time as the element changes state and (de)activates
    its pads.

    https://bugzilla.gnome.org/show_bug.cgi?id=755342

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list