[Bug 755505] ges: trivial leakages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755505

--- Comment #11 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Justin J. Kim from comment #9)
> Review of attachment 312000 [details] [review]:
> 
> ::: ges/ges-uri-asset.c
> @@ +598,2 @@
>    if (g_str_has_prefix (priv->uri, GES_MULTI_FILE_URI_PREFIX)) {
> +    trackelement = GES_TRACK_ELEMENT (ges_multi_file_source_new (uri));
> 
> Up to this point, this is exactly same as left, but the different thing is
> whether uri is freed at line 612.
> I think I cannot free priv->uri directly because it is used by the other
> functions.

My mistake, thanks for the explanation.

(In reply to Justin J. Kim from comment #10)
> Review of attachment 311999 [details] [review]:
> 
> ::: ges/ges-timeline-element.c
> @@ -263,1 +263,3 @@
>    G_OBJECT_CLASS (ges_timeline_element_parent_class)->finalize (self);
> +
> +  if (object_name_counts)
> 
> I thought the lifecycle of object_name_counts variable should be same with
> timeline-lement because it is defined as static and local variable.

https://phabricator.freedesktop.org/diffusion/GES/browse/master/ges/ges-timeline-element.c;0b900bddc9eb534535e57c42afd27b6fc8d97399$39

I am not sure what you mean, did I miss something? :)

> If the purpose of this quark container is to trace object number, how about
> replacing this with atomic operations like 'g_atomic_int_inc' to make code
> simple?

It is a bit more complex than that as we keep a counter for each object type
(name).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.