[Bug 755392] video: bugs with gst_video_frame_copy and videoconvert (with test scripts)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755392

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312044|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312044:
 --> (https://bugzilla.gnome.org/review?bug=755392&attachment=312044)

::: gst-libs/gst/video/video-converter.c
@@ +2178,3 @@
+    case GST_VIDEO_FORMAT_r210:
+    case GST_VIDEO_FORMAT_GBR_10LE:
+    case GST_VIDEO_FORMAT_GBR_10BE:

instead of hardcoding this, you can get this information from the
GstVideoFormat.

::: gst-libs/gst/video/video-dither.c
@@ +321,3 @@
           if (shift[k] < 8)
             v = v >> (8 - shift[k]);
+          p[n_comp * j + k] = v >> additional_shift;

It could just do that based on the GstVideoFormat that is passed in
gst_video_dither_new(). From the format it can know if it's 16 bit, 10 bit, 8
bit or anything else.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.