[Bug 755542] gtk: Fix a race where we end up setting wrong VideoInfo

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755542

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312057|none                        |reviewed
             status|                            |

--- Comment #3 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 312057:
 --> (https://bugzilla.gnome.org/review?bug=755542&attachment=312057)

One question.

::: ext/gtk/gtkgstbasewidget.c
@@ +456,3 @@

+  if (gst_video_info_is_equal (&widget->v_info, v_info) &&
+      gst_video_info_is_equal (&widget->pending_v_info, v_info)) {

Shouldn't his only check pending_v_info?

The pending_v_info is used to cache changes before drawing>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.