[Bug 755169] dashdemux: can we have multiple seek events at the same time?

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755169

--- Comment #41 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 312064:
 --> (https://bugzilla.gnome.org/review?bug=755169&attachment=312064)

these ones found at a quick review. I'll start a more thorough review now.

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +127,3 @@
   guint32 segment_seqnum;
+
+  GRecMutex api_lock;

why does it need to be recursive?

@@ +561,1 @@
   return gst_pad_event_default (pad, parent, event);

api_lock should be released after gst_pad_event_default

@@ +2182,3 @@
     if (GST_CLOCK_TIME_IS_VALID (demux->segment.stop)
         && stream->segment.position >= stream->segment.stop) {
+      GST_MANIFEST_LOCK (demux);

this should be unlock

@@ +2190,3 @@
     if (GST_CLOCK_TIME_IS_VALID (demux->segment.start)
         && stream->segment.position < stream->segment.start) {
+      GST_MANIFEST_LOCK (demux);

this should be unlock

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.