[Bug 755169] dashdemux: can we have multiple seek events at the same time?

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 25 03:29:46 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755169

--- Comment #45 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> ---
(In reply to Florin Apostol from comment #44)
> (In reply to Vincent Penquerc'h from comment #43)
> > The API lock needs to be recursive because we end up in two event handlers
> > at one point, in the same thread. I can't recall which exactly, but I could
> > rechange the code to reproduce the lock if you want.
> > 
> A recursive mutex is dangerous. We really should understand why it is
> needed. I think it can be avoided. The original developer avoided it in one
> scenario using demux->priv->exposing. Maybe we can do this here too, for the
> particular scenario that caused you problems.

Something like this may be possible, I'll have a look.

> > The api lock is released just before that line.
> I can't identify that place. Can you recall the scenario? Don't need to
> prove it, just describe it.

I can't recall just now, but I'll reproduce it and post. That line about api
lock was a reply to "api_lock should be released after gst_pad_event_default",
though:


  g_rec_mutex_unlock (&demux->priv->api_lock);

  return gst_pad_event_default (pad, parent, event);
}


I may be slow to reply today, I seem to be not getting any bugzilla mail
notifications.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list