[Bug 753920] dvdlpcmdec: factor out common code to set output format into new function

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753920

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Version|1.5.2                       |git master
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.7.1

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks. When updating an existing patch in bugzilla, please also mark the
previous version of the patch as obsolete by ticking the checkbox next to the
old patch when attaching the new one, thanks.

I have pushed this with three very minor changes:

 - prefixed update_audio_formats with gst_dvdlpcmdec_
 - added the bug url to the commit message at the end
 - changed your clear-text name in 'Author'

commit d7f78391b4490b896df2f06d7c73676a7fc616f6
Author: HoonHee Lee <hoonhee.lee at lge.com>
Date:   Tue Aug 25 10:08:46 2015 +0900

    dvdlpcmdec: factor out common code to set output format into new function

    When caps event is recieved and header is changed, reordering channel
    and setting the default output format for audio are processed. These 2 of
    code are same. Thus, It is better to make a new function for these common
    code in terms of removing duplicated code, maintenance and expansion.

    https://bugzilla.gnome.org/show_bug.cgi?id=753920


I also noticed this while looking at the patch:

commit d57b0971987598c73ce96c9026d422c94712caae
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sat Sep 26 09:23:05 2015 +0100

    dvdlpcmdec: fix invalid read beyond channel position array

    We would always copy sizeof(sorted_position) bytes, which is
    for 8 channels, but if we have less than 8 channels the
    position array we copy from will only have allocated space
    for channel channels, so we would read beyond the input
    array in some cases.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.