[Bug 685282] dvdspu: figure out how to make it work with hardware decoders and subpicture overlays

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=685282

--- Comment #39 from Jan Schmidt <thaytan at noraisin.net> ---
(In reply to Arnaud Vrac from comment #37) 
> > 
> > Instead of only scaling down to fit, is it worth considering using the
> > set-frame-size event to allocate a larger downstream frame as the target for
> > blending into? I think in any case a mechanism for communicating the
> > intended display size to the sinks would be useful when using
> > GstVideoOverlayComposition.  I have a rip here where the video was
> > originally 1080p, and they've trimmed the black-bars to enode 1920x800. When
> > the black bars are added back in for display, the PGS titles should appear
> > there - starting below Y=870 or so.
> 
> I'm not sure what to do here. Right now I have the exact same result as VLC
> for vobsub and PGS. mpv renders PGS slightly differently, it doesn't scale
> them.
> 

To take an example sub from the test sample I'm talking about:

Win ID 0 x 404 y 872 w 1111 h 142

So that means on the original disc, this was targeted to display from y=872 to
1014.

With 140 pixel black bars ((1080 - 800) / 2) added to the 1920x800 video, then
the video displays from 140 -> 940 on the screen. The sub should cover y = 872
to 1014, so should appear at the bottom of the video, with about 74 pixels
sticking off the bottom.

On a real disc, the video would actually be encoded at 1920x1080, so the
placement would be a non-issue.

btw, can you please update the remaining patches on the bug?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.