[Bug 755772] nlecomposition lost its GClosure actions

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755772

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312345|none                        |needs-work
             status|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 312345:
 --> (https://bugzilla.gnome.org/review?bug=755772&attachment=312345)

::: plugins/nle/nlecomposition.c
@@ +335,2 @@
       g_closure_unref ((GClosure *) act);
+      comp->priv->actions = g_list_remove_link (comp->priv->actions, removed);

I do not understand why you can not use g_list_delete_link as it should free
the node as we want, what am I missing? :)

@@ +378,3 @@
     g_value_set_object (&params[0], comp);

+    lact = g_list_first (priv->actions);

This is the same thing.

@@ +1019,3 @@
   priv->dispose_has_run = TRUE;

+  g_list_foreach (priv->objects_start, _remove_each_nleobj, comp);

g_list_free full?

(some for the followings :))

@@ +2342,3 @@
+  }
+
+  ret = GST_ELEMENT_CLASS (parent_class)->change_state (element, transition);

Why did you move that?

I do not think it is related to the leaks is it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.