[Bug 755772] nlecomposition lost its GClosure actions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Sep 30 03:43:26 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755772

--- Comment #6 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 312345:
 --> (https://bugzilla.gnome.org/review?bug=755772&attachment=312345)

::: plugins/nle/nlecomposition.c
@@ +335,2 @@
       g_closure_unref ((GClosure *) act);
+      comp->priv->actions = g_list_remove_link (comp->priv->actions, removed);

OK

@@ +1019,3 @@
   priv->dispose_has_run = TRUE;

+  g_list_foreach (priv->objects_start, _remove_each_nleobj, comp);

Indeed, all right.

@@ +2342,3 @@
+  }
+
+  ret = GST_ELEMENT_CLASS (parent_class)->change_state (element, transition);

I still do not understand what exact problem it solve.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list