[Bug 755169] dashdemux: can we have multiple seek events at the same time?

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Sep 30 09:18:58 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=755169

--- Comment #62 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 312313:
 --> (https://bugzilla.gnome.org/review?bug=755169&attachment=312313)

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +1321,3 @@
+  GST_ADAPTIVE_DEMUX_SEEKING_UNLOCK (demux);
+  if (use_lock)
+    GST_ADAPTIVE_DEMUX_API_LOCK (demux);

this deadlocks in my scenario (explained in comment 55). In that case the query
was called from gst_adaptive_demux_sink_event case GST_EVENT_EOS. You added
protection only for cases when query is called from seek.

By the way, how do you intend to prove that the system doesn't deadlock (for
example there aren't other scenarios except seek and sink_event in which query
can be called from the same thread so it should not get the API_LOCK)?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list