[Bug 764421] video{utils,decoder}: split allocation query caps and pad caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764421

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325094|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325094:
 --> (https://bugzilla.gnome.org/review?bug=764421&attachment=325094)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3810,3 @@
     state->caps = gst_video_info_to_caps (&state->info);
+  if (state->alloc_caps == NULL)
+    state->alloc_caps = gst_caps_ref (state->caps);

So the negotiate() implementation of the subclass would set this to something
if needed? Maybe allocation_caps instead of omitting half a word?

::: gst-libs/gst/video/gstvideoutils.h
@@ +69,1 @@
   GstBuffer *codec_data;

This breaks ABI. You can't insert a new field somewhere in the middle

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.