[Bug 754438] oggdemux misbehaviour when seeking

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754438

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325137|none                        |reviewed
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325137:
 --> (https://bugzilla.gnome.org/review?bug=754438&attachment=325137)

::: ext/ogg/gstoggdemux.c
@@ +1958,2 @@
   ogg = pad->ogg;
+  if (ogg->discard_till_flush)

What if this boolean is just set after the line? Don't we have to discard
buffers that are queued up already when receiving FLUSH_STOP or something? This
seems racy

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.