[Bug 764421] libs: (audio, video) split allocation query caps and pad caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764421

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325146|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325146:
 --> (https://bugzilla.gnome.org/review?bug=764421&attachment=325146)

::: gst-libs/gst/audio/audio-info.h
@@ +81,3 @@
   gint                      bpf;
   GstAudioChannelPosition   position[64];
+  GstCaps                  *allocation_caps;

This shouldn't be part of the GstAudioInfo. It has nothing to do with it and
also breaks ABI (assumption is that GstAudioInfo does not have to be freed).

It has to be stored in something in the encoder/decoder base class, like the
GstVideoCodecState in the video ones.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.