[Bug 752213] tee: Avoid race condition while forwarding sticky events

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752213

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325079|none                        |needs-work
             status|                            |

--- Comment #38 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325079:
 --> (https://bugzilla.gnome.org/review?bug=752213&attachment=325079)

::: plugins/elements/gsttee.c
@@ +141,3 @@
   gboolean removed;
+
+  gboolean do_fw_sticky_events;

Maybe "initial_sticky_events_pending" is more descriptive. This is not about
general forwarding of them, but of the very initial ones.

@@ -416,3 @@
   GST_OBJECT_FLAG_SET (srcpad, GST_PAD_FLAG_PROXY_CAPS);
-  /* Forward sticky events to the new srcpad */
-  gst_pad_sticky_events_foreach (tee->sinkpad, forward_sticky_events, srcpad);

By *not* copying the sticky events here, the tee srcpad is not going to have
any caps/segment/etc anymore. This might break some application assumptions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.