[Bug 764319] videorate : avoid useless buffer copy un drop-only mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764319

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|---                         |FIXED

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 6788003912f5e261530e854e64ebbfe2f9591207
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sun Apr 3 11:40:50 2016 +0300

    videorate: Don't fill up the segment with duplicate buffers if
drop_only==TRUE

commit eda44c640e3257fb36a9ed2e48a4b2ad0411f6ec
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sun Apr 3 11:38:28 2016 +0300

    videorate: Remove dead code

    We never get into this code path at all if drop_only==TRUE.

commit 2626c02149ab7947cec9890215a76bddb643554c
Author: Frédéric Bertolus <frederic.bertolus at parrot.com>
Date:   Tue Mar 29 17:19:41 2016 +0200

    videorate: avoid useless buffer copy in drop-only mode

    Make writable the buffer before pushing it lead to a buffer copy. It's
    because a reference is keep for the previous buffer.
    The previous buffer reference is only need to duplicate the buffer. In
    drop-only mode, the previous buffer is release just after pushing the
    buffer so a copy is done but it's useless.

    https://bugzilla.gnome.org/show_bug.cgi?id=764319

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.