[Bug 764361] gdpdepay: query for buffer allocator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764361

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325067|accepted-commit_now         |committed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325067:
 --> (https://bugzilla.gnome.org/review?bug=764361&attachment=325067)

I've pushed this with some minor changes:

::: gst/gdp/dataprotocol.c
@@ +494,3 @@
 GstBuffer *
+gst_dp_buffer_from_header (guint header_length, const guint8 * header,
+    GstAllocator * allocator, GstAllocationParams allocation_params)

The allocation_params should be passed by reference, not value. Copying them
here for every function call is not ideal and not needed

::: gst/gdp/gstgdpdepay.c
@@ +534,3 @@
       gst_adapter_clear (this->adapter);
+      if (this->allocator)
+        gst_object_unref (this->allocator);

You have to set the allocator to NULL after getting rid of the reference, and
also the allocation parameters should be reset.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.