[Bug 756000] gstrtmpsink: add unlock

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756000

--- Comment #14 from Håvard Graff (hgr) <havard.graff at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #13)
> (In reply to Tim-Philipp Müller from comment #12)

> > I don't entirely understand this comment, could you elaborate what you mean?
> > Are you talking about the TCP protocol level or some other protocol? Isn't
> > this mostly an implementation detail? The rtmp implementation could surely
> > be done in a way that's always fully async and fully interruptible (worst
> > case you leave behind a thread that's stuck in some non-async connect or dns
> > lookup, no?)?
> 
> That could be another way to support librtmp indeed. Spawn a thread, and do
> everything in that single thread.  That thread would ensure client/server
> state stay sane, whatever happens. We know the librtmp is not thread-safe,
> we should probably stop hacking around.

Except you will still be left with the problem I clearly demonstrate in the
supplied tests, and this patch solves: unblocking an ongoing connect or write.
Also, what do you mean by librtmp not being thread-safe? We have had
conferences with 50+ people connected using rtmp, and have not had any issues.
What issues have you had with it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.