[Bug 764421] libs: (audio, video) split allocation query caps and pad caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764421

--- Comment #10 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #9)
> Review of attachment 325146 [details] [review]:
> 
> ::: gst-libs/gst/audio/audio-info.h
> @@ +81,3 @@
>    gint                      bpf;
>    GstAudioChannelPosition   position[64];
> +  GstCaps                  *allocation_caps;
> 
> This shouldn't be part of the GstAudioInfo. It has nothing to do with it and
> also breaks ABI (assumption is that GstAudioInfo does not have to be freed).
> 
> It has to be stored in something in the encoder/decoder base class, like the
> GstVideoCodecState in the video ones.

Yes, I'm a bit lost in audio. My approach now is to add allocate_caps in
GstAudio{De,En}coderContext (part of element's private data structure) and add
a method gst_audio_{en,de}coder_set_allocation_caps ();

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.