[Bug 764707] segment: Modifiy inside segment condition

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764707

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325516|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325516:
 --> (https://bugzilla.gnome.org/review?bug=764707&attachment=325516)

::: gst/gstsegment.c
@@ +887,3 @@
    * we're outside of the segment */
+  if (G_UNLIKELY (segment->stop != -1 && start != -1 && (start > segment->stop
+              || (segment->start != segment->stop && start ==
segment->stop))))

Can you provide a unit test for this too?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.