[Bug 764769] matroskamux: make timecodescale configurable

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 8 10:26:02 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=764769

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 325576
  --> https://bugzilla.gnome.org/attachment.cgi?id=325576
make timecodescale configurable

>+  g_object_class_install_property (gobject_class, PROP_TIMECODESCALE,
>+      g_param_spec_int64 ("timecodescale", "TimecodeScale used to calculate "
>+          "the Raw Timecode of a Block",
>+          "Using the default (1000000) you'll get block with "
>+          "milliseconds precision, using 1 nanoseconds precision", 1,
>+          GST_SECOND, DEFAULT_TIMECODESCALE,
>+          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

I think this should be something like:

"timecodescale", "TimecodeScale", "TimecodeScale used to calculate the Raw
Timecode of a Block".

Don't see why you need to describe the defaults here, and we may want to change
the default in future (e.g. be adaptive based on the input framerate or such to
minimise rounding errors).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list