[Bug 764798] New: rtspsrc Critical errors when connecting with TLS / rtsps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764798

            Bug ID: 764798
           Summary: rtspsrc Critical errors when connecting with TLS /
                    rtsps
    Classification: Platform
           Product: GStreamer
           Version: 1.8.0
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: jake.foytik at ipconfigure.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

When connecting to RTSP with TLS enabled, rtspsrc posts CRITICAL errors related
to the keymgmt header. 

The gst_mikey_message_new_from_caps() function in gstmikey.c expects
"srtp-cipher" and "srtp-auth" to be set and they are not. In gstrtspsrc.c, the
default_srtcp_param() function creates the caps:

  caps = gst_caps_new_simple ("application/x-srtp",
      "srtp-key", GST_TYPE_BUFFER, buf,
      "srtcp-cipher", G_TYPE_STRING, "aes-128-icm",
      "srtcp-auth", G_TYPE_STRING, "hmac-sha1-80", NULL);

Should this be changed to:

  caps = gst_caps_new_simple ("application/x-srtp",
      "srtp-key", GST_TYPE_BUFFER, buf,
      "srtcp-cipher", G_TYPE_STRING, "aes-128-icm",
      "srtcp-auth", G_TYPE_STRING, "hmac-sha1-80",
      "srtp-cipher", G_TYPE_STRING, "aes-128-icm",
      "srtp-auth", G_TYPE_STRING, "hmac-sha1-80", NULL);

Also, it appears the gst_mikey_message_new_from_caps() function requires
"srtcp-cipher" and "srtcp-auth" to be set, but these values are never used.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.