[Bug 764629] qtdemux: Support sidx based seek in pull mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764629

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325412|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325412:
 --> (https://bugzilla.gnome.org/review?bug=764629&attachment=325412)

Generally looks good, thanks. Just some remarks

::: gst/isomp4/qtdemux.c
@@ +220,3 @@
   GstClockTime ts;
   guint64 moof_offset;
+  gboolean ref_type;            /* only used for sidx */

It might be nicer to directly use the GstSidxBox/GstSidxBoxEntries here. We
might want to use more information from them later, and have them from the
parser anyway

@@ +2306,3 @@
+
+  if (stream->seg_idx_entries)
+    g_free (stream->seg_idx_entries);

g_free() is NULL-safe, no need for the "if" here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.