[Bug 764873] gldeinterlace: enable this plugin on OpenGL ES using a simple deinterlace fragment shader

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Apr 13 04:57:10 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=764873

--- Comment #8 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Matthew Waters (ystreet00) from comment #5)
> Review of attachment 325707 [details] [review]:
> 
> I think this should be behind a property, say method, like the deinterlace
> element in -good.  There's nothing technically prohibiting enabling this
> (vertical blur) shader (and the existing greedyh one everywhere).  In fact,
> all that's required is to add a property and merge the two _callback()
> implementations.
> 
> ::: ext/gl/gstgldeinterlace.c
> @@ +200,3 @@
>  
> +  GST_GL_BASE_FILTER_CLASS (klass)->supported_gl_api =
> +      GST_GL_API_OPENGL | GST_GL_API_GLES2;
> 
> gles2 shaders are also supported for OpenGL3.

Hi Matthew,
I have refine the gldeinterlace, help me review the code. Thanks a lot.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list