[Bug 764948] decodebin: use-buffering property ignored on non-muxed streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764948

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325802|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325802:
 --> (https://bugzilla.gnome.org/review?bug=764948&attachment=325802)

::: gst/playback/gstdecodebin2.c
@@ +2403,3 @@
+     */
+    is_decoder = strstr (gst_element_factory_get_metadata (factory,
+            GST_ELEMENT_METADATA_KLASS), "Decoder") != NULL;

For decoders this might not be correct. The uridecodebin property says "Perform
buffering on demuxed/parsed media", and for decoded data at least the
buffer-size property doesn't make too much sense.

Should probably print a warning in the debug output if the decoder case
happens. It's better than not doing any buffering messages at all probably, but
far from ideal. Fortunately we have parsers for about every codec that can
exist outside containers.

@@ +2405,3 @@
+            GST_ELEMENT_METADATA_KLASS), "Decoder") != NULL;
+
+    if (!chain->parent && (is_parser || is_decoder) && dbin->use_buffering)

There is a problem here if use_buffering is set to TRUE afterwards. We wouldn't
dynamically insert a multiqueue then. But that shouldn't be much of a problem

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.