[Bug 764744] Crash when using a shared factory and TLS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764744

--- Comment #11 from Jake Foytik <jake.foytik at ipconfigure.com> ---
Yea, it seems like it was incorrect before as well. 

I'm able to get around the crash by removing line rtsp-stream.c:1120
(gst_element_set_locked_state()). I would expect this to have some
repercussions, but the streams have been playing fine. Do you know why the
element is set to locked?

I think the correct solution would be to have rtsp-stream maintain a handle to
all of the udpsrcs created for the shared media and have them properly cleaned
up when a client disconnects. In the current implementation, it is possible to
have a lot of udpsrcs needlessly hanging around if a shared media has been open
for a long time with multiple clients connecting and disconnecting. It looks
like the sending side of the pipeline is cleaned up in the update_transport()
function where the "remove" signal is called on the multiudpsink. Should we not
clean up the udpsrcs here too?

I have confirmed this crash is not related to the TLS configuration. Looking
back at my first comment, I originally thought the two issues were related but
that appears to be incorrect. Should I create another bug for the SRTP issue?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.