[Bug 764964] Build fails because gdk_display_get_device_manager is deprecated

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Apr 14 06:38:00 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=764964

--- Comment #4 from Alex Băluț <alexandru.balut at gmail.com> ---
(In reply to Thibault Saunier from comment #3)
> Review of attachment 325882 [details] [review]:
> 
> ::: validate/plugins/gtk/gstvalidategtk.c
> @@ +143,3 @@
>      return NULL;
>    }
> +#if GTK_CHECK_VERSION(3,20,0)
> 
> I think that part should rather go into the get_device function

The new API can be used to get the master keyboard directly, there is no need
for get_device anymore. 

If you insist, either we make get_device less generic and rename it to
get_keyboard, or to keep it generic *maybe* we can use
https://developer.gnome.org/gdk3/stable/GdkSeat.html#gdk-seat-get-slaves with
accepts a GdkSeatCapabilities parameter (instead of GdkInputSource).
Basically:
- gdk_seat_get_slaves does:
  return seat_class->get_slaves (seat, capabilities);
- gdk_seat_get_keyboard does:
   return seat_class->get_master (seat, GDK_SEAT_CAPABILITY_KEYBOARD);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list