[Bug 764316] vaapidecode: simplify downstream negotiation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764316

--- Comment #32 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #28)
> Review of attachment 325738 [details] [review]:
> 
> ::: gst/vaapi/gstvaapidecode.c
> @@ +390,3 @@
> +    /* allocation caps changes if cropping differs */
> +    alloc_changed = output_width != surface_width
> +        || output_height != surface_height;
> 
> if state == NULL and if output size is equal to surface size, then the
> allocation size is zero.
> 
> Thus, in gst_vaapidecode_update_src_caps() 
> 
>   if (decode->allocation_width != 0 || decode->allocation_height != 0) {
>       state->allocation_caps = ...
> 
> This means that the state allocation caps is not assigned. Later, if in
> gstvideodecoder, if allocation_caps is not assigned (NULL) the negotiation
> caps are used for allocation query too.
> 
I understood it, but IMHO it is confusing for someone who read/experiment with
the code. Even printing allocation_width/allocation_height (that too globally
maintained) will show NULL values...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.