[Bug 758548] vaapipostproc: Allow video scaling using capsfilter
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Apr 14 16:39:26 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=758548
--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Hi Scott!!!
Sorry for delaying this review :(
I just started today and the patch is huge! I wonder if it is possible to break
it down into smaller commits to ease the review O:)
As a initial comment I think that the class attribute filter_formats_list it is
not necessary since it is only used at caps negotiation, and it is not that cpu
intensive: converting an integer array into a string array. So, instead of a
class attribute a function to call when caps negotiation.
Also, I thing that gst_vaapipostproc_supported_caps_features() can be
simplified using gst_vaapi_caps_feature_contains(), but not sure if it is less
expensive.
And that is it for now. :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list