[Bug 765079] srtpdec request-key is not signaled if roc is missing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765079

Josep Torra Valles <n770galaxy at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326059|accepted-commit_now         |committed
             status|                            |

--- Comment #2 from Josep Torra Valles <n770galaxy at gmail.com> ---
Comment on attachment 326059
  --> https://bugzilla.gnome.org/attachment.cgi?id=326059
look for "roc" in caps

commit 73ebdb888e047b14ceea19ce1a0bbbeff0cd7b2a
Author: Aleix Conchillo Flaqué <aconchillo at gmail.com>
Date:   Thu Apr 14 22:32:05 2016 -0700

    srtpdec: also check for "roc" in caps

    Currently, gst_srtp_dec_sink_setcaps is happy if the "roc" field is not
    provided in the caps. If it is not provided the stream will be properly
    inserted in the hash table with a default "roc". Then, when the first
    buffer arrives validate_buffer will find an existing stream in the hash
    table and will not signal request-key, not allowing the user to provide
    a "roc".

    This patch expects "roc" in gst_srtp_dec_sink_setcaps, if not found a
    request-key will be signaled and the user will be able to provide all
    the srtp fields, including "roc".

    https://bugzilla.gnome.org/show_bug.cgi?id=765079

-- 
You are receiving this mail because:
You are the QA Contact for the bug.