[Bug 657076] audioringbuffer: may fail to provide running clock

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=657076

--- Comment #14 from Jan Schmidt <thaytan at noraisin.net> ---
Reverted those 2 commits:

commit 802eae296a95334412ce4a6ab26d36fba52f99cc
Author: Jan Schmidt <jan at centricular.com>
Date:   Sat Apr 16 02:11:59 2016 +1000

    Revert "audioringbuffer: start ringbuffer if needed upon commit"

    This reverts commit 13ee94ef1091f8a8a90dbd395b39876c26c5188e.

    Causes audio glitches at startup by starting to output segments
    from the ringbuffer before it has been filled / fully prerolled.

    https://bugzilla.gnome.org/show_bug.cgi?id=657076

commit 46a3c9ac8b2f8182ef8f211f4be09a67e4d42a61
Author: Jan Schmidt <jan at centricular.com>
Date:   Sat Apr 16 02:17:26 2016 +1000

    Revert "pulsesink: uncork if needed upon commit"

    This reverts commit 0dd46accf6d282ff07065852bd91c85c78af3394.

    With some audiosinks, starting the ringbuffer on the first commit
    causes audio glitches at startup by starting to output segments
    from the ringbuffer before it has been filled / fully prerolled. This
    doesn't usually happen with pulsesink because we map the pulseaudio
    ringbuffer directly, but we should keep things consistent with
    other sinks with regards to startup latency, plus it gives more
    headway to avoid glitching, should the initial 2nd segment take
    more than 10ms to generate.

    https://bugzilla.gnome.org/show_bug.cgi?id=657076

Not sure if I should now just close this bug?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.