[Bug 755523] teletextdec: add property to show/hide hidden content

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755523

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312034|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312034:
 --> (https://bugzilla.gnome.org/review?bug=755523&attachment=312034)

::: ext/teletextdec/gstteletextdec.c
@@ +366,3 @@
+    case PROP_CONCEAL:
+      teletext->concealed = g_value_get_boolean (value);
+//      gst_teletextdec_update (teletext);

Why is this commented out? (Also don't use C++/C99 comments)

Should update() be called on the next opportunity here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.