[Bug 765183] Add 'jack' variant that builds JACK elements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765183

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326210|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326210:
 --> (https://bugzilla.gnome.org/review?bug=765183&attachment=326210)

::: recipes/gst-plugins-good-1.0.recipe
@@ +132,3 @@

+        if self.config.variants.jack:
+            self.deps += ['jack']

You also need to add jack to the dependencies of the package that ships the
plugin

::: recipes/jack.recipe
@@ +3,3 @@
+
+class Recipe(recipe.Recipe):
+    name = 'jack'

Having a jack recipe does not seem ideal. It will potentially conflict with any
version that is already available on the system. It might be better to just
depend on jack in bootstrap

::: recipes/libsndfile.recipe
@@ +2,3 @@
+
+class Recipe(recipe.Recipe):
+    name = 'libsndfile'

With this we can also enable the sndfile plugin in gst-plugins-bad. FWIW, it
would be best to have each new recipe as a single commit and then another
commit that adds the jack variant and uses it in gst-plugins-good.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.