[Bug 765260] New: baseparse: regression with aac streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765260

            Bug ID: 765260
           Summary: baseparse: regression with aac streams
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: bilboed at bilboed.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

This was introduced by https://bugzilla.gnome.org/show_bug.cgi?id=765096

The scenario that fails is the following:
* The input to aacparse never has any DTS, only PTS
* The first buffer contains bogus data (i.e. no data starts there), the 2nd
buffer will start with valid header/data.
* For simplicity, the first PTS is 0, the second 1, the third 2, ...

When the first buffer arrives, we end up with the following computed values:
* prev_pts : 0 , prev_dts : 0, next_pts : 0, next_dts : 0
Nothing is pushed, quite a bit of data is skipped

when the second buffer arrives, we end up with the following computed values:
* prev_pts : 1 , prev_dts : 0 , next_pts : 1, next_dts : 0
There isn't enough data yet to push out a parsed frame

The 3rd buffer arrives, we have the same computed values (we didn't consume
anything from the adapter)
* prev_pts : 1 , prev_dts : 0 , next_pts : 1, next_dts : 0
We end up parsing and pushing a frame with ... PTS:1 and DTS:0
 => This is wrong, the DTS should also be 1

There is more data in the adapter to be parsed, we end up with the following
computed values:
* prev_pts : 2 , prev_dts : 0 , next_pts : 2, next_dts : 1
We end up parsing and pushing a frame with PTS:2 DTS:1
  => Same problem

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.