[Bug 763454] dash: Fix the bug when inheriting segmentbase, segmentTemplate or segmentList from grandparent

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763454

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323836|none                        |needs-work
             status|                            |

--- Comment #7 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 323836:
 --> (https://bugzilla.gnome.org/review?bug=763454&attachment=323836)

Thanks for the patch, still some things to fix.

Also, I manually added the test here and it failed. It also gave me some
warnings during compilation.

::: tests/check/elements/dash_mpd.c
@@ +796,3 @@
+ *
+ */
+GST_START_TEST (dash_mpdparser_inherit_segmentTemplate_from_period)

You should add the function to the test cases in the main at the bottom of the
file otherwise it won't be run.

@@ +2718,3 @@
  *
  * Description of bistreamSwitching attribute in Period:
+ * "When set to ¡¥true¡¦, this is equivalent as if the

This seems to be unrelated to the rest of the patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.