[Bug 765292] gl:cocoa:Fix incompatible type warning

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765292

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326382|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326382:
 --> (https://bugzilla.gnome.org/review?bug=765292&attachment=326382)

::: sys/applemedia/vtenc.c
@@ +840,3 @@
   }
 #ifdef HAVE_VIDEOTOOLBOX_10_9_6
+  if (&VTCompressionSessionPrepareToEncodeFrames) {

I think this is wrong. We're checking here if that function exists. It will be
NULL if it does not exist because of using -weak_framework to link to
VideoToolbox. This is to make sure the plugin works against all versions of VT
but works better with newer versions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.