[Bug 742878] decklink: Add initial support for 10bit YUV modes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742878

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326338|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326338:
 --> (https://bugzilla.gnome.org/review?bug=742878&attachment=326338)

Maybe gst-indent would've been better as a separate commit :) Otherwise almost
good to go, just some simple things

::: sys/decklink/gstdecklink.cpp
@@ +130,3 @@
+    {GST_DECKLINK_VIDEO_FORMAT_10BIT_RGBX, "10bit-rgbx",
"bmdFormat10BitRGBX"},
+    {0, NULL, NULL}
+  };

I think it would be good to comment out the ones here that we don't support
yet. They can stay in the enum, but at least they won't show up in gst-inspect
for now then

::: sys/decklink/gstdecklinkvideosink.cpp
@@ +208,3 @@

+  g_object_class_install_property (gobject_class, PROP_VIDEO_FORMAT,
+      g_param_spec_enum ("video-format-type", "Video format type",

video-format, not video-format-type

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +164,3 @@

+  g_object_class_install_property (gobject_class, PROP_VIDEO_FORMAT,
+      g_param_spec_enum ("video-format-type", "Video format type",

video-format, not video-format-type

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.