[Bug 765302] Missing MVC support in gstplayer. Attaching patch for fix.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765302

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326397|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326397:
 --> (https://bugzilla.gnome.org/review?bug=765302&attachment=326397)

Thanks for your patch! It would be good to additionally have setter/getter
functions for this too

::: gst-libs/gst/player/gstplayer.c
@@ +591,3 @@
+    case PROP_VIDEO_MULTIVIEW_MODE:
+      g_object_set (G_OBJECT (self->playbin), "video-multiview-mode",
+          g_value_get_enum (value), NULL);

You could use g_object_set_value() here to prevent the GValue round-trip

@@ +692,3 @@
+      GstVideoMultiviewFramePacking v;
+      g_object_get (G_OBJECT (self->playbin), "video-multiview-mode", &v,
NULL);
+      g_value_set_enum (value, v);

You could use g_object_get_value() here to prevent the GValue round-trip

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.