[Bug 765302] player: Add support for multiview settings

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765302

--- Comment #2 from barunsingh <barun.singh at samsung.com> ---
(In reply to Sebastian Dröge (slomo) from comment #1)
> Review of attachment 326397 [details] [review]:
> 
> Thanks for your patch! It would be good to additionally have setter/getter
> functions for this too
> 
> ::: gst-libs/gst/player/gstplayer.c
> @@ +591,3 @@
> +    case PROP_VIDEO_MULTIVIEW_MODE:
> +      g_object_set (G_OBJECT (self->playbin), "video-multiview-mode",
> +          g_value_get_enum (value), NULL);
> 
> You could use g_object_set_value() here to prevent the GValue round-trip
> 
> @@ +692,3 @@
> +      GstVideoMultiviewFramePacking v;
> +      g_object_get (G_OBJECT (self->playbin), "video-multiview-mode", &v,
> NULL);
> +      g_value_set_enum (value, v);
> 
> You could use g_object_get_value() here to prevent the GValue round-trip

Mr. Sebastian,

I will do the changes and upload the patch. Also, I am working on to find other
list of features/api that we can add in gstplayer element. Tomorrow I will
start a new discussion for this.

Thanks
Barun Kr. Singh

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.