[Bug 765302] player: Add support for multiview settings

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765302

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326469|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326469:
 --> (https://bugzilla.gnome.org/review?bug=765302&attachment=326469)

::: gst-libs/gst/player/gstplayer.c
@@ +3725,3 @@
+ *  (6): row-interleaved  - GST_VIDEO_MULTIVIEW_FRAME_PACKING_ROW_INTERLEAVED
+ *  (7): top-bottom       - GST_VIDEO_MULTIVIEW_FRAME_PACKING_TOP_BOTTOM
+ *  (8): checkerboard     - GST_VIDEO_MULTIVIEW_FRAME_PACKING_CHECKERBOARD

You don't have to include all the possible values here btw, it will get out of
date and people can just click on the enum type in the docs to get to it anyway

@@ +3730,3 @@
+gst_player_get_multiview_mode (GstPlayer * self)
+{
+  /* Initialize mode with default value */

And this comment is not really needed :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.