[Bug 765302] player: Add support for multiview settings

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765302

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326473|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 326473:
 --> (https://bugzilla.gnome.org/review?bug=765302&attachment=326473)

Thanks, just some minor things and cosmetic changes below :)

::: gst-libs/gst/player/gstplayer.c
@@ +3714,3 @@
+ *
+ * Returns: The current value of @type, Default: -1 "none". In case of
+ *   error default value is returned.

Add a "Since: 1.10" to all the new functions

@@ +3727,3 @@
+
+  return val;
+

Please remove the empty lines at the end of all functions, and at the beginning

@@ +3745,3 @@
+  g_return_if_fail (GST_IS_PLAYER (self));
+
+  g_object_set (self, "video-multiview-mode", &mode, NULL);

Without the &

@@ +3786,3 @@
+  g_return_if_fail (GST_IS_PLAYER (self));
+
+  g_object_set (self, "video-multiview-flags", &flags, NULL);

Without the &

::: gst-libs/gst/player/gstplayer.h
@@ +24,2 @@
 #include <gst/gst.h>
+#include <gst/video/video-info.h>

Include gst/video/video.h here, and it also will have to be added to the
pkg-config file then

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.