[Bug 763647] mpegtsmux doesn't keep language code from the incoming audio stream
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Apr 21 12:58:22 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=763647
--- Comment #3 from mguinzbourg <mguinzbourg at gmail.com> ---
(In reply to Thiago Sousa Santos from comment #1)
> Created attachment 326322 [details] [review]
> mpegtsmux: write language descriptor when language is available
>
> Please check if this fixes your issue.
>
> The remaining question I have here is whether the language code should be
> added only for audio streams or any stream. Also it seems that language
> assumed to be english when nothing is set from upstream, but this seems like
> a separate issue.
>
> Patch still missing documentation for the new mpegts function, to be added
> before pushing.
I need your help with the verification of the fix. I can't build gstreamer from
the source. My project is built on Windows 64 bit platform and I'm using
pre-built binaries for Visual Studio solution. I would really appreciate if
tyou can send me a patched binaries so I can try them, or instruct me how to
obtain them.
So far I've examined the changes and I see that this should fix my problem with
audio streams.
As for the video streams - I don't need them for my project but if it's easy to
add support for video streams I don't see why not.
If the language is not set currently it shows up as unknown which is perfectly
fine. I think in order to handle it better you can let the user to set default
language and set the default code when language is not defined for the stream.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list