[Bug 765431] aggregator: Check all pads for data when live

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765431

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #326555|none                        |needs-work
             status|                            |

--- Comment #2 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 326555:
 --> (https://bugzilla.gnome.org/review?bug=765431&attachment=326555)

Looks good to me, but

::: gst-libs/gst/base/gstaggregator.c
@@ -449,1 @@
-    if (gst_aggregator_pad_queue_is_empty (pad) && !pad->priv->eos) {

Why did you remove the code that deals with EOS ? If EOS has been received, the
pad should not be counted as empty.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.